-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests and methods with AMD ROCM #36
Conversation
Codecov Report
@@ Coverage Diff @@
## backendcls #36 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 9 9
Lines 977 992 +15
============================================
+ Hits 977 992 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
One possibility to avoid the if self.engine.name == "cupy" and self.engine.is_hip
checks would be to rename the current CupyBackend
to CUDABackend
and create a new HIPBackend
that inherits it and re-implements the required methods that do not work for hip. This would require to define some new methods in the backends.AbstractBackend
here. As discussed with @mlazzarin it would be better to first merge this to #35 to avoid having many open PRs and we could consider this refactoring later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlazzarin thanks for this. Let's merge this now and keep the inheritance for a future PR.
Closes #34.
rocblas_status_not_implemented
issue by using NumPy instead of CuPy foreigh
andeigvalsh
.The changes apply only to CuPy with AMD GPUs.
In order to close #34, we need also to merge qiboteam/qibo#501 in the Qibo repository.